summaryrefslogtreecommitdiffstats
path: root/pykolab
Commit message (Collapse)AuthorAgeFilesLines
...
* With this patch I'm trying to introduce a file-type object in logger, which ↵Liutauras Adomaitis2018-05-177-28/+65
| | | | | | | | | | | | | | | | | | could swallow everything thrown to stderr (and possibly stdout) and redirect to python logger. Python smtplib debug mode prints everything to stderr, but when wallace runs... Summary: ...in fork mode stderr is not available (Bad file descriptor error) and thus wallace traceback when it tries to send emails Test Plan: none Reviewers: vanmeeuwen, machniak, petersen Reviewed By: vanmeeuwen Subscribers: petersen, machniak, vanmeeuwen Maniphest Tasks: T2498, T2163, T3751 Differential Revision: https://git.kolab.org/D577
* In some cases kolabd fails to cleanly update IMAP mailbox after LDAP ↵Liutauras Adomaitis2018-03-121-6/+1
| | | | | | | | | | | | | | | | | | | changes. That is usual when result_attribute value is in upper case. Mailbox modification seems to follow slightly different code path, by shortcutting to IMAP pykolab function... Summary: ..."has_folder()" instead of going via "user_mailbox_exists()", which has a code to downcase mailbox name. Do not shortcut to "has_folder()" function, use "user_mailbox_exists()" to downcase mailbox name before checking if it exists. Test Plan: none Reviewers: vanmeeuwen, machniak Reviewed By: machniak Subscribers: adomaitis, petersen, machniak, vanmeeuwen Differential Revision: https://git.kolab.org/D571
* Fix the problem with undelete-mailbox command when listing deleted mailboxes ↵Liutauras Adomaitis2018-03-121-2/+1
| | | | | | | | | | | | | | | | | | command actually doesn't replace placeholders with values, which prevents correctly list deleted mailboxes and then undelete them. Summary: T2648 Test Plan: none Reviewers: vanmeeuwen, machniak, mollekopf Reviewed By: mollekopf Subscribers: mollekopf, machniak, vanmeeuwen Maniphest Tasks: T2648 Differential Revision: https://git.kolab.org/D548
* Fixing the undelete-mailbox in murder topology to a different root folderLiutauras Adomaitis2018-03-081-5/+11
| | | | | | | | | | | | | | | | Summary: T2307 Test Plan: none Reviewers: vanmeeuwen, machniak Reviewed By: vanmeeuwen Subscribers: machniak, vanmeeuwen Maniphest Tasks: T2307 Differential Revision: https://git.kolab.org/D551
* Fix typoJeroen van Meeuwen (Kolab Systems)2018-01-241-1/+1
|
* No definition for subject -- it's aci_subjectJeroen van Meeuwen (Kolab Systems)2018-01-241-8/+30
|
* Catch additional exceptions we know the cause ofJeroen van Meeuwen (Kolab Systems)2018-01-241-0/+18
|
* Include what we fail on, when we fail on somethingJeroen van Meeuwen (Kolab Systems)2018-01-241-4/+27
|
* LDAP remove referrals for correct handling in Samba 4Jeroen van Meeuwen (Kolab Systems)2017-07-221-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary: LDAP user authentication does not work when using Samba 4 as LDAP backend. Samba 4 (as well as MS AD) returns referrals (search continuations) for some objects. LDAPv3 does not specify which credentials should be used for the search continuations. **libldap** tries to anonymous bind and do the search continuations, which fails with Samba 4 (as well as MS AD). Kolab 16 will fail while authenticating with **ldap.OPERATIONS_ERROR** and the error message //00002020: Operation unavailable without authentication// The submitted patch is supposed to be used with ``` REFERRALS off ``` in /etc/ldap.conf and should not affect any other situations. Eventually setting LDAP option via ``` ldap.OPT_REFERRALS, 0 ``` would be an option too, but i can't test at the moment, if there is any impact on non Samba 4 setups. The change in wallace addresses the same problem, as i got ``` 2017-07-05 12:27:28,566 pykolab.wallace ERROR Module resources.heartbeat() failed with error: Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/wallace/__init__.py", line 89, in modules_heartbeat modules.heartbeat(module, lastrun) File "/usr/lib/python2.7/dist-packages/wallace/modules.py", line 128, in heartbeat return modules[name]['heartbeat'](*args, **kw) File "/usr/lib/python2.7/dist-packages/wallace/module_resources.py", line 438, in heartbeat resource_dns = [dn for dn in resource_dns if resource_base_dn in dn] TypeError: argument of type 'NoneType' is not iterable ``` Test Plan: Use Kolab 16 with Samba 4. Try to authenticate user. Should fail. Disable Referrals in /etc/ldap.conf with ``` REFERRALS off ``` and try again. Now you should no longer see the **ldap.OPERATIONS_ERROR** but an auth fail because of 4 (or at least more than one) results returned. The referrals no longer will be automatically queried, but returned as part of the results containing //None// on the position 0 (result-type) of the result tuple. Apply the patch now, which will remove those //None// result-type results. The Authentication should succeed. Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: #pykolab_developers Tags: #kolab_16 Differential Revision: https://git.kolab.org/D467
* Merge branch 'arcpatch-D479'Aleksander Machniak2017-07-211-1/+2
|\
| * Fix error on CLASS:X-PERSONALAleksander Machniak2017-07-211-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary: This X-* property is standard, but not supported by Kolab format. Though we should not bail out, we should just ignore the value not the whole iTip. Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: vanmeeuwen Differential Revision: https://git.kolab.org/D479
* | Support unicode characters in event location field (Bifrost#T29104)Aleksander Machniak2017-07-211-1/+1
|/
* Allow a folder we intend to clean up the ACL entries for, to have ↵Jeroen van Meeuwen (Kolab Systems)2017-02-221-11/+14
| | | | | | disappeared by the time we get around to it. Reference bifrost#T14032
* Correct "waited for 30 seconds" -> "waited for 15 seconds"Jeroen van Meeuwen (Kolab Systems)2017-02-221-1/+1
|
* Fix and unify IMAP reconnection on folder create with Murder (Bifrost#T23626)Aleksander Machniak2017-02-221-46/+48
| | | | | | | | | | | Summary: Fixes non-working reconnection after 30 seconds of waiting Note: Not tested with Murder. Also, do we really need this code with max_tries? Reviewers: #pykolab_developers Differential Revision: https://git.kolab.org/D378
* Avoid trickery in the annotation name and shared namespaceJeroen van Meeuwen (Kolab Systems)2016-12-201-5/+7
|
* Set system keepalive parameters on the IMAP socketJeroen van Meeuwen (Kolab Systems)2016-12-131-0/+18
|
* Retry finding a folder in a murder for 30 seconds, then reconnectJeroen van Meeuwen (Kolab Systems)2016-12-131-0/+10
| | | | When disconnecting an unqualified connection, eliminate all connections
* More detailed verbosity when not able to set_entry_attributes()Jeroen van Meeuwen (Kolab Systems)2016-12-021-2/+4
|
* Vastly improve the speed of conflict detection between recurring events ↵Jeroen van Meeuwen (Kolab Systems)2016-12-021-45/+59
| | | | | | (with or without exceptions, neither, one or both) Reference T1988
* If neither the existing kolab event nor the incoming iTip event have any ↵Jeroen van Meeuwen (Kolab Systems)2016-12-021-0/+4
| | | | | | recurrence rules, they need to iterations either. Reference T1988
* No conflict needs to be detected if the incoming iTip is a transparent event ↵Jeroen van Meeuwen (Kolab Systems)2016-12-021-0/+3
| | | | | | either. Reference T1988
* Do not continue attempting to create sub-folders for a user's mailbox if the ↵Jeroen van Meeuwen (Kolab Systems)2016-12-021-1/+13
| | | | | | creation of the mailbox for the user has failed. Reference T5881
* I'm outta breath.Jeroen van Meeuwen (Kolab Systems)2016-11-181-0/+3
|
* Sigh, Debian, deep sigh.Jeroen van Meeuwen (Kolab Systems)2016-11-181-0/+8
|
* Sigh, Debian. :/Jeroen van Meeuwen (Kolab Systems)2016-11-182-0/+8
|
* Use the correct encoding for folders in delete-mailbox-acl.Jeroen van Meeuwen (Kolab Systems)2016-11-031-2/+2
| | | | Reference Bifrost T10492
* T1417: Fix so sync-mailhost-attr uses result_attribute not mail_attributesAleksander Machniak2016-10-063-11/+17
| | | | | | | | | | | | Summary: Fixes T1417 Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Maniphest Tasks: T1417 Differential Revision: https://git.kolab.org/D209
* T1375: Fix setting metadata on dovecotAleksander Machniak2016-10-062-5/+5
| | | | | | | | | | | | Summary: Fixes T1375 Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Maniphest Tasks: T1375 Differential Revision: https://git.kolab.org/D211
* T1221: Fix a "race" between Event and Todo properties_map dictAleksander Machniak2016-10-061-0/+3
| | | | | | | | | | | | Summary: Fixes T1221 Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Maniphest Tasks: T1221 Differential Revision: https://git.kolab.org/D216
* T1414: Set LDAP TIMEOUT option only on "immediate" connectionAleksander Machniak2016-10-061-2/+3
| | | | | | | | | | | | | | | | | Summary: Fixes T1414. Shouldn't we handle ldap.TIMEOUT exception in authenticate()? Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: pokorra, thozie Maniphest Tasks: T1414 Differential Revision: https://git.kolab.org/D208
* subprocess call for freshclam needs to use collection for the parametersTimotheus Pokorra2016-10-051-2/+2
| | | | | | | | | | | | | | Summary: fix compiler error: TypeError: bufsize must be an integer Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: #pykolab_developers Tags: #pykolab Differential Revision: https://git.kolab.org/D238
* T1461: Convert windows timezones into Olson format in iTipAleksander Machniak2016-09-301-4/+32
| | | | | | | | | | | | | | | | Summary: iCalendar is used to parse iTip data, but it does not support windows tz. Fixes T1461 Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: vanmeeuwen Maniphest Tasks: T1461 Differential Revision: https://git.kolab.org/D219
* Add configuring freshclamJeroen van Meeuwen (Kolab Systems)2016-09-301-0/+22
|
* The defaults need to be more strictJeroen van Meeuwen (Kolab Systems)2016-09-091-2/+2
|
* Resolve T1454Jeroen van Meeuwen (Kolab Systems)2016-08-261-4/+14
|
* T1373: Fix untraslated "PENDING" label in invitation notificationAleksander Machniak2016-07-221-0/+1
| | | | | | | | | | | | | | | Summary: Fixes T1373 Note: This could be also fixed by using "NEEDS-ACTION" label in wallace intead of "PENDING". Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Maniphest Tasks: T1373 Differential Revision: https://git.kolab.org/D198
* Resolve finding no entries, too many entries, and ensure that LDAP failures ↵Jeroen van Meeuwen (Kolab Systems)2016-07-221-21/+172
| | | | | | | | | | | | | | | | | | | | | are triggered immediately Summary: Resolve T1171 and T1318 Test Plan: Authenticate with attribute values configured, duplicate and non-existent, correct and incorrect passwords. Expect the corresponding successes and failures. Reviewers: #pykolab_developers, machniak Reviewed By: machniak Subscribers: machniak Maniphest Tasks: T1171, T1318 Differential Revision: https://git.kolab.org/D199
* Do not fail pykolab.auth on a pykolab.imap error (#5453)Jeroen van Meeuwen (Kolab Systems)2016-07-061-4/+7
|
* Use the correct constants import and __version__ value from itJeroen van Meeuwen (Kolab Systems)2016-07-011-2/+2
|
* Eliminate get_entry_attribute() in setup_ldapAleksander Machniak2016-06-291-15/+5
| | | | | | | | | | | | | | Summary: This is redundant and can cause useless ldap re-connection. Small CS fixes Warning: This wasn't tested. Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Differential Revision: https://git.kolab.org/D182
* Regard the input as utf-8, convert to utf-7/imapJeroen van Meeuwen (Kolab Systems)2016-06-291-1/+1
|
* Fix issue with re-binding to an LDAP connection (T1318)Aleksander Machniak2016-06-271-26/+39
| | | | | | | | | | | | | | | Summary: Fixes T1318 Note that set_entry_attributes() will now use two LDAP connections, which may or may not be what we want. I didn't find a simple way of using ldap_priv connection in entry_dn() and get_entry_attributes(). Reviewers: #pykolab_developers Maniphest Tasks: T1318 Differential Revision: https://git.kolab.org/D188
* Set no quota if the quota for the root folder is 0Jeroen van Meeuwen (Kolab Systems)2016-06-201-0/+4
|
* Use the correct credentials to bind withJeroen van Meeuwen (Kolab Systems)2016-06-091-1/+1
|
* Determine shared folder resource using kolabTargetFolder attribute (#5337)Aleksander Machniak2016-05-183-11/+112
| | | | | | | | | | | | | | Summary: It's supposed to fix #5337. WARNING: Untested!!!!!!!! Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: vanmeeuwen Differential Revision: https://git.kolab.org/D130
* Normalize objectclass attribute values (#5423)Aleksander Machniak2016-05-181-0/+11
| | | | | | | | | | | | Summary: Fixes objectclass member comparison in cmd-sync #5423 Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: vanmeeuwen, vendel.colja Differential Revision: https://git.kolab.org/D156
* Fix error when calling list-domain-mailboxes without argumentsAleksander Machniak2016-05-131-0/+1
| | | | | | | | Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Differential Revision: https://git.kolab.org/D154
* Fix handling of folder name encoding in list-deleted-mailboxes (#5318)Aleksander Machniak2016-05-131-4/+5
| | | | | | | | | | Summary: Fixes #5318 Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Differential Revision: https://git.kolab.org/D153
* Trim spaces in surname/givenname/sn when generating mail/alias (#5360)Aleksander Machniak2016-05-131-8/+15
| | | | | | | | | | Reviewers: vanmeeuwen, #pykolab_developers Reviewed By: vanmeeuwen, #pykolab_developers Subscribers: vanmeeuwen Differential Revision: https://git.kolab.org/D136