summaryrefslogtreecommitdiffstats
path: root/wallace
Commit message (Collapse)AuthorAgeFilesLines
* Fix error in the footer moduleHEADmasterAleksander Machniak5 days1-2/+2
|
* Add footer_position option, so the added footer content can be also placed ↵Aleksander Machniak2021-11-031-6/+27
| | | | | | | | | | | | on top Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: #pykolab_developers Differential Revision: https://git.kolab.org/D2996
* Fix error when running signature module without any config (Bifrost#T243288)Aleksander Machniak2019-11-251-1/+1
|
* restore system umask after fork (fix T5659)Daniel Hoffend2019-11-181-1/+3
| | | | | | | | | | | | Summary: start-stop-daemon behaviour has changed. We must make sure the created pidfile is "secure" and not world-wide-writeable. Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Differential Revision: https://git.kolab.org/D847
* More linting and syntax issues resolvedJeroen van Meeuwen (Kolab Systems)2019-10-252-62/+77
|
* Introduce a configurable timeout for simple search and authentication requests.Jeroen van Meeuwen (Kolab Systems)2019-10-251-139/+309
| | | | | Fix linting issues Increase Python3 compatibility
* Set default value of --max-tasks to None, which effectively makes pool ↵Liutauras Adomaitis2019-08-211-1/+1
| | | | | | | | | | | | | | workers work forever. Summary: That should be a workaround for issue when multiprocessing spawns a process which never gets a task and that ends up with all pool processes not getting into a state to accept new task and emails start congest. Most probably that is a deadlock situation described in https://codewithoutrules.com/2018/09/04/python-multiprocessing/ . The solution is in Python3. Reviewers: vanmeeuwen Reviewed By: vanmeeuwen Subscribers: petersen, machniak Differential Revision: https://git.kolab.org/D803
* Avoid cancelling the status of an event that has not been foundJeroen van Meeuwen (Kolab Systems)2019-08-161-111/+248
| | | | | | | | | | | | | | Summary: Reference T123747 Test Plan: None Reviewers: #pykolab_developers, machniak Reviewed By: machniak Subscribers: #pykolab_developers Differential Revision: https://git.kolab.org/D629
* More logging in Wallace and --max-tasks per process option for wallacedLiutauras Adomaitis2019-08-168-31/+107
| | | | | | | | | | | | Summary: Given that part of https://git.kolab.org/D761 changes are obsolete after commit baeee0049f06430801a2d9940f875747e51be7f5 I still want to have some changes find their way in master. Test Plan: None Reviewers: vanmeeuwen Subscribers: petersen, machniak, vanmeeuwen Differential Revision: https://git.kolab.org/D791
* Kill harderJeroen van Meeuwen (Kolab Systems)2019-06-201-1/+1
|
* Append signatures from files, or templates using LDAP information and ↵Jeroen van Meeuwen (Kolab Systems)2019-06-181-0/+248
| | | | | | | | | | | | | | | conditionals. Summary: Resolves T1279 Test Plan: None Reviewers: #pykolab_developers, machniak Maniphest Tasks: T1279 Differential Revision: https://git.kolab.org/D167
* Implement multiprocessing part of D761, letting wallace restart cleanly and ↵Jeroen van Meeuwen (Kolab Systems)2019-06-182-169/+265
| | | | fast.
* Better detect resource collections who already delegated the event.Jeroen van Meeuwen (Kolab Systems)2019-05-171-1/+5
| | | | Rebase D611 by @fjl
* Fix SIGPIPE errors in wallace due to closing stderr and reusing FD2 by @fjlJeroen van Meeuwen (Kolab Systems)2019-05-171-0/+4
|
* More debug logging which should be useful to track message transportation in ↵Liutauras Adomaitis2019-05-151-1/+5
| | | | wallace
* T4611: Add missing `import random`Aleksander Machniak2019-01-301-0/+1
|
* Make wallace skip message files which are in locks directoryLiutauras Adomaitis2018-12-141-2/+9
| | | | | | | | | | | | | | Summary: Wallace should not try to work with lock files Test Plan: None Reviewers: vanmeeuwen, machniak Reviewed By: vanmeeuwen Subscribers: petersen Differential Revision: https://git.kolab.org/D708
* Fix exception when handling iTip CANCEL for a reasource event (Bifrost#T123747)Aleksander Machniak2018-08-201-2/+4
|
* Avoid the use of duplicate names for functions and in-function scope ↵Jeroen van Meeuwen (Kolab Systems)2018-07-311-3/+3
| | | | | | variables where both are used in the same scope Reference T123747
* Manage the pool processes such that they die after a limited quantity of ↵Jeroen van Meeuwen (Kolab Systems)2018-07-273-48/+116
| | | | | | | | | | | | | | | | | | | | | time, and pick up messages from the spool asynchronously. Summary: Reference T75735 Let a single worker process timeout itself Set the signal as late as possible Abstract the method to pickup messages from the spool, so that a new recurring Timer may pick up messages out of the spool Test Plan: * Run messages through it Reviewers: #pykolab_developers Subscribers: #pykolab_developers Differential Revision: https://git.kolab.org/D617
* Fix using Attendee object in a debug messageAleksander Machniak2018-06-271-1/+1
|
* Check if the variable is not None before using strip()Aleksander Machniak2018-06-211-2/+6
|
* Ignore iTip dummy comments with whitespace chars only (e.g. from Outlook)Aleksander Machniak2018-06-211-0/+2
|
* Fix invitationpolicy error on an itip reply with no ORGANIZER prop ↵Aleksander Machniak2018-06-211-2/+6
| | | | (Bifrost#T114576)
* nother attempt to add more logging and fix wallace messages not being ↵Liutauras Adomaitis2018-06-153-11/+25
| | | | | | | | | | | | | | | | delivered and staying in spool directory Summary: Adding more logs that should show why _sendmail function does not start a "while" delivery loop and unliking file does not happen. Also some code polishing. Test Plan: none Reviewers: machniak, vanmeeuwen Reviewed By: machniak Subscribers: petersen Differential Revision: https://git.kolab.org/D599
* Fix D577 patch bug - modules._sendmail result assign to variable, which is ↵Liutauras Adomaitis2018-06-042-16/+3
| | | | | | | | | | | | | | | | used to log the result of email sending. Summary: Define success variable to hold the _sendmail result. Test Plan: none Reviewers: vanmeeuwen, machniak Reviewed By: machniak Subscribers: petersen Differential Revision: https://git.kolab.org/D581
* With this patch I'm trying to introduce a file-type object in logger, which ↵Liutauras Adomaitis2018-05-173-86/+70
| | | | | | | | | | | | | | | | | | could swallow everything thrown to stderr (and possibly stdout) and redirect to python logger. Python smtplib debug mode prints everything to stderr, but when wallace runs... Summary: ...in fork mode stderr is not available (Bad file descriptor error) and thus wallace traceback when it tries to send emails Test Plan: none Reviewers: vanmeeuwen, machniak, petersen Reviewed By: vanmeeuwen Subscribers: petersen, machniak, vanmeeuwen Maniphest Tasks: T2498, T2163, T3751 Differential Revision: https://git.kolab.org/D577
* Address inefficiencies and possible misfunction over delegated mailboxes in ↵Jeroen van Meeuwen (Kolab Systems)2017-07-221-27/+72
| | | | | | | | | | | | | | | | | | other user namespace Summary: Resolves T2582 Test Plan: None Reviewers: #pykolab_developers, machniak, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: adomaitis, machniak, #pykolab_developers Maniphest Tasks: T2582 Differential Revision: https://git.kolab.org/D485
* Little change to improve invitation policy logging - log if iTip requires ↵Liutauras Adomaitis2017-07-221-1/+1
| | | | | | | | | | | | re-scheduling and print event uid Summary: Little change to improve invitation policy logging - log if iTip requires re-scheduling and print event uid Reviewers: vanmeeuwen Reviewed By: vanmeeuwen Differential Revision: https://git.kolab.org/D491
* LDAP remove referrals for correct handling in Samba 4Jeroen van Meeuwen (Kolab Systems)2017-07-221-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Summary: LDAP user authentication does not work when using Samba 4 as LDAP backend. Samba 4 (as well as MS AD) returns referrals (search continuations) for some objects. LDAPv3 does not specify which credentials should be used for the search continuations. **libldap** tries to anonymous bind and do the search continuations, which fails with Samba 4 (as well as MS AD). Kolab 16 will fail while authenticating with **ldap.OPERATIONS_ERROR** and the error message //00002020: Operation unavailable without authentication// The submitted patch is supposed to be used with ``` REFERRALS off ``` in /etc/ldap.conf and should not affect any other situations. Eventually setting LDAP option via ``` ldap.OPT_REFERRALS, 0 ``` would be an option too, but i can't test at the moment, if there is any impact on non Samba 4 setups. The change in wallace addresses the same problem, as i got ``` 2017-07-05 12:27:28,566 pykolab.wallace ERROR Module resources.heartbeat() failed with error: Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/wallace/__init__.py", line 89, in modules_heartbeat modules.heartbeat(module, lastrun) File "/usr/lib/python2.7/dist-packages/wallace/modules.py", line 128, in heartbeat return modules[name]['heartbeat'](*args, **kw) File "/usr/lib/python2.7/dist-packages/wallace/module_resources.py", line 438, in heartbeat resource_dns = [dn for dn in resource_dns if resource_base_dn in dn] TypeError: argument of type 'NoneType' is not iterable ``` Test Plan: Use Kolab 16 with Samba 4. Try to authenticate user. Should fail. Disable Referrals in /etc/ldap.conf with ``` REFERRALS off ``` and try again. Now you should no longer see the **ldap.OPERATIONS_ERROR** but an auth fail because of 4 (or at least more than one) results returned. The referrals no longer will be automatically queried, but returned as part of the results containing //None// on the position 0 (result-type) of the result tuple. Apply the patch now, which will remove those //None// result-type results. The Authentication should succeed. Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: #pykolab_developers Tags: #kolab_16 Differential Revision: https://git.kolab.org/D467
* A delegated mailbox may in fact not have a result attributeJeroen van Meeuwen (Kolab Systems)2016-12-131-1/+5
|
* Format tracebacks in to legible formJeroen van Meeuwen (Kolab Systems)2016-12-131-1/+1
|
* Convert potential date to datetimeJeroen van Meeuwen (Kolab Systems)2016-12-021-1/+1
| | | | Resolves T1847
* T1399: Implemented ACT_REJECT policy for resourcesAleksander Machniak2016-10-061-12/+29
| | | | | | | | | | | | Summary: Fixes T1399 Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Maniphest Tasks: T1399 Differential Revision: https://git.kolab.org/D217
* Implement a more verbose return message for process_message() (Resolves T1199)Jeroen van Meeuwen (Kolab Systems)2016-07-071-1/+1
|
* Use COMMENT in invitation policy notifications (#5403)Aleksander Machniak2016-07-011-15/+60
| | | | | | | | | | | | Summary: Fixes #5403 Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: vanmeeuwen Differential Revision: https://git.kolab.org/D159
* Severely reduce the default number of threads from 24 to 4Jeroen van Meeuwen (Kolab Systems)2016-06-201-1/+1
|
* Prevent from AttributeError when stopping wallaceAleksander Machniak2016-05-131-2/+4
| | | | | | | | | | | | Summary: Sometimes self.pool may not exists when killing wallace process Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: vanmeeuwen Differential Revision: https://git.kolab.org/D137
* Fix encoding of text parts with footer added (#5414)Aleksander Machniak2016-05-041-14/+18
| | | | | | | | | | Summary: Fixes #5414 Reviewers: #pykolab_developers Subscribers: vendel.colja Differential Revision: https://git.kolab.org/D151
* Fix default folder selection for new invitation objects (#5378)Aleksander Machniak2016-04-151-15/+15
| | | | | | | | | | | | Summary: Fixes #5378. Makes that folders marked as default are prefered over other folders when savin pending invitation objects Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: venc Differential Revision: https://git.kolab.org/D132
* Catch exceptions from modules to prevent from killing the wallace process ↵Aleksander Machniak2016-04-141-1/+5
| | | | | | | | | | | | | | (#5370) Summary: Fixes issue where IMAP connection problems would kill wallace (#5370) Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Subscribers: vanmeeuwen Differential Revision: https://git.kolab.org/D125
* Add note to cancellation notification body that it's for single occurrence ↵Aleksander Machniak2016-04-141-0/+3
| | | | | | | | | | | | when it is (#5375) Summary: Fixes #5375 Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Differential Revision: https://git.kolab.org/D124
* Add missing "import traceback" (#5366)Aleksander Machniak2016-04-041-0/+1
| | | | | | | | | | Summary: Fixes #5366 Reviewers: #pykolab_developers Subscribers: vennen, petersen, venc Differential Revision: https://git.kolab.org/D113
* Respect content encoding of the message part when adding a footer (#5087)Aleksander Machniak2016-04-041-2/+2
| | | | | | | | Summary: Untested Reviewers: #pykolab_developers Differential Revision: https://git.kolab.org/D116
* Fix typos in notification messagesAleksander Machniak2016-04-041-4/+4
| | | | | | Reviewers: #pykolab_developers Differential Revision: https://git.kolab.org/D119
* Fix From header encoding in invitation notifications (#4258)Aleksander Machniak2016-04-041-4/+8
| | | | | | | | | | Summary: Fixes https://issues.kolab.org/show_bug.cgi?id=4258 Reviewers: #pykolab_developers, vanmeeuwen Reviewed By: #pykolab_developers, vanmeeuwen Differential Revision: https://git.kolab.org/D120
* Update bugzilla url to https://issues.kolab.org.Jeroen van Meeuwen (Kolab Systems)2016-02-291-2/+2
| | | | Resolves T1044
* make wallace module gpgencrypt handling multipart messagesJeroen van Meeuwen (Kolab Systems)2016-02-081-6/+58
| | | | | | | | | | | | | Summary: The wallace module gpgencrypt can't deal with multipart messages. So messages with attachments get unreadable on some/most email clients if they where encrypted by wallace. This patch should generate a correct open pgp encrypted multipart message. Reviewers: #pykolab Projects: #pykolab Differential Revision: https://git.kolab.org/D30
* Wallace does not have an attribute thread_countJeroen van Meeuwen (Kolab Systems)2015-08-141-1/+0
|
* Also consider the --port option an integer (#4960)Jeroen van Meeuwen (Kolab Systems)2015-08-131-0/+1
|